> On March 13, 2014, 8:41 a.m., David Faure wrote: > > It would have been better to just put a local copy of that desktop file > > into the kservice autotests subdir, so that it's always available to run > > the test on. > > Now we depend on konsolerun.desktop which might change in the future, etc. > > And this way we can add stuff to the desktop file to test more "Actions" > > features in the future.
Yeah, I vaguely intended to move to that in the future; I mostly made this change so I could check that some other changes *really* didn't break any tests. But I'll look at doing that change up front. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/#review52874 ----------------------------------------------------------- On March 12, 2014, 3:47 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116766/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 3:47 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kservice > > > Description > ------- > > Use a desktop file we might find for testing KServiceActions > > The screensaver stuff isn't ported to frameworks 5 yet, so looking for > those desktop files won't work. This uses something that might actually > be installed instead. > > > Diffs > ----- > > autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 > autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 > > Diff: https://git.reviewboard.kde.org/r/116766/diff/ > > > Testing > ------- > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
