----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/#review53812 -----------------------------------------------------------
This review has been submitted with commit a2cd603db5191c49df18488d68dd891b901b63af by Alex Merry to branch master. - Commit Hook On March 23, 2014, 1:51 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116934/ > ----------------------------------------------------------- > > (Updated March 23, 2014, 1:51 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > Use KPluginLoader to find kioslaves > > KIO slaves are typically installed in PLUGIN_INSTALL_DIR, rather than > QT_PLUGIN_INSTALL_DIR, so we should use KPluginLoader instead of > QPluginLoader to locate them. > > > Diffs > ----- > > src/core/slave.cpp ee84066f96675caaf1fa5ba612c8242eac160c4a > src/kioslave/CMakeLists.txt 64bf7e0f36a1a407dd162e2c0461dedb2f57a13e > src/kioslave/kioslave.cpp 50413d04be29361638ba581383354d79881e844e > > Diff: https://git.reviewboard.kde.org/r/116934/diff/ > > > Testing > ------- > > Ran kioslavetest, both with and without KDE_FORK_SLAVES=1 set, and got it to > list /tmp. kio_file.so was found each time. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
