----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/#review57207 -----------------------------------------------------------
src/platformtheme/kdeplatformfiledialoghelper.cpp <https://git.reviewboard.kde.org/r/117976/#comment39871> No default? The Qt docs say that "AnyFile" is the default. http://qt-project.org/doc/qt-5/qfiledialog.html#fileMode-prop So that will result in something like: case QFileDialogOptions::FileMode::AnyFile: case default: m_file.... break; I like your test! Looks a lot like the one i wrote for the view mode :) +1 from me after the default case is implemented. - Mark Gaiser On May 3, 2014, 3:27 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117976/ > ----------------------------------------------------------- > > (Updated May 3, 2014, 3:27 p.m.) > > > Review request for KDE Frameworks. > > > Repository: frameworkintegration > > > Description > ------- > > This implements support for QFileDialog::setFileMode. > Obsolete value QFileDialog::DirectoryOnly is ignored. > > Autotest was added to test all FileModes. > > > Diffs > ----- > > autotests/kfiledialog_unittest.cpp 69d474c > src/platformtheme/kdeplatformfiledialoghelper.h c59bee9 > src/platformtheme/kdeplatformfiledialoghelper.cpp 777d818 > > Diff: https://git.reviewboard.kde.org/r/117976/diff/ > > > Testing > ------- > > The file dialog works as expected, autotests pass. > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
