> On May 4, 2014, 12:53 p.m., David Faure wrote: > > Thanks! > > > > Anything else from options() that we're not handling?
>From a quick look, FileDialogOption::DontConfirmOverwrite option is unhandled. This one is easy: dialog->m_fileWidget->setConfirmOverwrite(!options()->testOption(QFileDialogOptions::DontConfirmOverwrite)); There are also other unhandled options: labelText (should be doable with setting the label of according widgets) sidebarUrls, history, FileDialogOption::ReadOnly (not sure what to do) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/#review57244 ----------------------------------------------------------- On May 3, 2014, 4:38 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117976/ > ----------------------------------------------------------- > > (Updated May 3, 2014, 4:38 p.m.) > > > Review request for KDE Frameworks. > > > Repository: frameworkintegration > > > Description > ------- > > This implements support for QFileDialog::setFileMode. > Obsolete value QFileDialog::DirectoryOnly is ignored. > > Autotest was added to test all FileModes. > > > Diffs > ----- > > autotests/kfiledialog_unittest.cpp 69d474c > src/platformtheme/kdeplatformfiledialoghelper.h c59bee9 > src/platformtheme/kdeplatformfiledialoghelper.cpp 777d818 > > Diff: https://git.reviewboard.kde.org/r/117976/diff/ > > > Testing > ------- > > The file dialog works as expected, autotests pass. > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
