-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118019/
-----------------------------------------------------------
(Updated May 6, 2014, 9:23 p.m.)
Review request for KDE Frameworks, David Faure and Martin Gräßlin.
Changes
-------
- No find_package(XCB ...) anymore, use QX11Extras_FOUND instead.
- Runtime check for platform.
Built-tested also with if(NOT QX11Extras_FOUND), runtime-tested against
systemsettings.
Bugs: 332532
https://bugs.kde.org/show_bug.cgi?id=332532
Repository: kdbusaddons
Description
-------
Update X11 app timestamp before activating window: This patch updates the
window's timestamp before sending the signal to the app to raise the window.
This makes raising the window following requestActivated work. It needs a
handler in the app, though, to do the actual call to
QMainWindow->activateWindow().
This part at least *could* go into KDBusAddons, perhaps conditionally
(HAVE_X11?). Otherwise, we'd have to do this also in every single app that
requires it.
Feedback?
Diffs (updated)
-----
CMakeLists.txt fe5feaf
src/CMakeLists.txt 7c0c485
src/config-kdbusaddons.h.cmake PRE-CREATION
src/kdbusservice.cpp 4239e85
Diff: https://git.reviewboard.kde.org/r/118019/diff/
Testing
-------
Implemented handler in systemsettings, verified that the window is raised on
second start.
Thanks,
Sebastian Kügler
_______________________________________________
Kde-frameworks-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
