> On May 6, 2014, 9:42 p.m., Alex Merry wrote: > > src/kdbusservice.cpp, lines 178-179 > > <https://git.reviewboard.kde.org/r/118019/diff/3/?file=271846#file271846line178> > > > > Use the QX11Info::isPlatformX11() one since you're using QX11Info > > anyway. The two lines are functionally equivalent, though.
Okay, thanks. Is the patch otherwise good to go in? - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118019/#review57455 ----------------------------------------------------------- On May 6, 2014, 9:23 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118019/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 9:23 p.m.) > > > Review request for KDE Frameworks, David Faure and Martin Gräßlin. > > > Bugs: 332532 > https://bugs.kde.org/show_bug.cgi?id=332532 > > > Repository: kdbusaddons > > > Description > ------- > > Update X11 app timestamp before activating window: This patch updates the > window's timestamp before sending the signal to the app to raise the window. > This makes raising the window following requestActivated work. It needs a > handler in the app, though, to do the actual call to > QMainWindow->activateWindow(). > > This part at least *could* go into KDBusAddons, perhaps conditionally > (HAVE_X11?). Otherwise, we'd have to do this also in every single app that > requires it. > > Feedback? > > > Diffs > ----- > > CMakeLists.txt fe5feaf > src/CMakeLists.txt 7c0c485 > src/config-kdbusaddons.h.cmake PRE-CREATION > src/kdbusservice.cpp 4239e85 > > Diff: https://git.reviewboard.kde.org/r/118019/diff/ > > > Testing > ------- > > Implemented handler in systemsettings, verified that the window is raised on > second start. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
