On Thursday 03 July 2014 13:31:16 Kevin Ottens wrote: > On Thursday 03 July 2014 10:08:13 David Faure wrote: > > On Thursday 03 July 2014 09:22:45 Kevin Ottens wrote: > > > On Thursday 03 July 2014 09:12:17 Marko Käning wrote: > > > > > Please pick one ASAP. > > > > > > > > Yes, please! > > > > > > You can help us there though, please locally revert the commit I > > > mentioned, > > > and confirm if that fixes the build for solid and allows to build all > > > the > > > way up to tier 3. I guess you might need to revert another of the > > > following > > > commits to get the tests to pass (I see an adjustment to the fake > > > backend > > > xml used for testing purpose only). > > > > Yes, please commit a fix. I can't test compilation on Mac myself. > > > > Kevin, Mario: which commits should be reverted exactly? > > As I mentionned in my initial mail, it should be > bb2374e19505d5c6a72039a46d55ec3f632192f4. I guess that > ca96df82f07e28f94c8bffb6fb22f32598b16abb will need to be reverted too to get > the tests to pass.
OK, if we decide to revert, this one would have to be reverted too: 2e3bfabc19c9cda217449c9ce4b50123edef8bc4 That should be all, I don't think I missed one. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
