2014-07-03 3:31 GMT-03:00 Kevin Ottens <er...@kde.org>: > Hello, > > On Wednesday 02 July 2014 08:33:01 Marko Käning wrote: >> on OSX solid fails to build because of this: >> >> --- >> /Users/marko/WC/KDECI-builds/solid/src/solid/devices/backends/iokit/iokitdev >> ice.cpp:227:25: error: allocating an object of abstract class type >> 'Solid::Backends::IOKit::Battery' iface = new Battery(this); >> ^ >> --- > > After a quick investigation it looks like the culprit is the commit > bb2374e19505d5c6a72039a46d55ec3f632192f4. It got reviewed as review number > 117339. > > It looks like there's a need to pay more attention to the multi-platform > aspects of libsolid when reviewing. > > Now we have the following choices: > 1) Add in the release notes that solid and most of Tier 3 won't build in > Windows and Mac OS X (aka we failed on the multiplatform promise on first > release, aka just great for PR); > 2) Revert the patch mentioned above and roll a new 5.0 (aka annoy David and > the packagers[*]); > 3) Produce a hot fix which ports the win and iokit backends propery and roll a > new 5.0 (aka metalworkers should get their ducks in order immediately, then > annoy David and the packagers[*]).
Solid builds just fine on Windows. Patrick von Reth was quick to add the missing methods in the Windows subclass, on 2e3bfabc1, review 118935. I think they are stubs though, but at least it builds. -- Nicolás _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel