> On July 8, 2014, 9:51 p.m., Albert Astals Cid wrote: > > I know i'm late, but if CMake provides one, can't we just kill ours?
The CMake one isn't quite compatible, so I wanted to keep this to make porting a little easier. Note that this is in kdelibs4support, and therefore deprecated. As soon as you stop your project finding kdelibs4support, it will no longer be available, and you will be using the CMake version. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119111/#review61935 ----------------------------------------------------------- On July 7, 2014, 5:27 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119111/ > ----------------------------------------------------------- > > (Updated July 7, 2014, 5:27 p.m.) > > > Review request for KDE Frameworks and Jonathan Riddell. > > > Repository: kdelibs4support > > > Description > ------- > > This version will accept the old GETTEXT_PROCESS_PO_FILES() syntax (no > PO_FILES argument), but will also accept the new syntax required by > CMake's version of this file. It will also warn when PO_FILES is not > given. > > > Diffs > ----- > > cmake/modules/FindGettext.cmake 91e88f7e00ac52539066e71eeffb7df6c2148196 > > Diff: https://git.reviewboard.kde.org/r/119111/diff/ > > > Testing > ------- > > None whatsoever: Jonathan, you know where this isssue has been seen, can you > test? > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
