----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/ -----------------------------------------------------------
(Updated July 14, 2014, 8:20 p.m.) Review request for KDE Frameworks and David Faure. Changes ------- Oops, used wrong group. Repository: kio Description ------- As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as Konqueror, to the KIO framework, where the URI Filters framework it configures resides as well. This makes more sense than stuffing it into workspace, since Web Shortcuts have many app level downstreams (e.g. Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and may not be running inside Plasma Desktop at the time. I've lightly modified the code to make it build, and made the naming more consistent - "webshortcuts" is now used throughout where previously was a mix of "ebrowsing" and "kurifilt". This does also mean the .po name changed, but the KCM only contains a single string. I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN redefinition, so I'd be happy for review. Diffs ----- src/kcms/webshortcuts/main.cpp PRE-CREATION src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION src/urifilters/ikws/CMakeLists.txt 4efe24e src/CMakeLists.txt 6f8373f src/kcms/CMakeLists.txt PRE-CREATION src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION src/kcms/webshortcuts/Messages.sh PRE-CREATION src/kcms/webshortcuts/main.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119280/diff/ Testing ------- Thanks, Eike Hein
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
