----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/#review64436 -----------------------------------------------------------
src/kcms/webshortcuts/main.cpp <https://git.reviewboard.kde.org/r/119280/#comment45020> Maybe it's time to update this example, altavista is gone... src/kcms/webshortcuts/main.cpp <https://git.reviewboard.kde.org/r/119280/#comment45021> (the word 'shortcut' is used twice for two different things here... prepend "keyboard" before the first one?) src/kcms/webshortcuts/main.cpp <https://git.reviewboard.kde.org/r/119280/#comment45019> The indentation seems wrong. Can you run astyle-kdelibs on the whole thing? It will also remove these pesky spaces inside parentheses. - David Faure On July 14, 2014, 8:36 p.m., Eike Hein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119280/ > ----------------------------------------------------------- > > (Updated July 14, 2014, 8:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konqueror, to the KIO framework, where the URI Filters framework it > configures resides as well. This makes more sense than stuffing it into > workspace, since Web Shortcuts have many app level downstreams (e.g. > Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and > may not be running inside Plasma Desktop at the time. > > I've lightly modified the code to make it build, and made the naming more > consistent - "webshortcuts" is now used throughout where previously was a mix > of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only > contains a single string. More importantly it means apps calling the KCM via > kcmshell5 need to be changed to use the new name - I promise to take care of > that. > > I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN > redefinition, so I'd be happy for review. > > Note the categorization is already what the recategorization effort > proscribed for this KCM. > > > Diffs > ----- > > src/CMakeLists.txt 6f8373f > src/kcms/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/Messages.sh PRE-CREATION > src/kcms/webshortcuts/main.h PRE-CREATION > src/kcms/webshortcuts/main.cpp PRE-CREATION > src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION > src/urifilters/ikws/CMakeLists.txt 4efe24e > > Diff: https://git.reviewboard.kde.org/r/119280/diff/ > > > Testing > ------- > > > Thanks, > > Eike Hein > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
