----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121118/#review70370 -----------------------------------------------------------
I don't know enough about any of this or the other review to give a shipit, but the general structure makes sense to me now :) - Albert Astals Cid On nov. 14, 2014, 12:36 p.m., Daniel Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121118/ > ----------------------------------------------------------- > > (Updated nov. 14, 2014, 12:36 p.m.) > > > Review request for KDE Frameworks, Albert Astals Cid and David Faure. > > > Repository: kemoticons > > > Description > ------- > > This patch is related to /r/121094, which moves KTextToHTML conversion > utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on > KEmoticons needed for smileys conversion, I created a plugin in KEmoticons > that implements the interface from KCoreAddons. This is based on the > FrameworkIntegrationPlugin. > > > Diffs > ----- > > CMakeLists.txt 1550bfe > autotests/CMakeLists.txt 29b7eb6 > autotests/ktexttohtmlplugintest.cpp PRE-CREATION > src/CMakeLists.txt 7b10087 > src/integrationplugin/CMakeLists.txt PRE-CREATION > src/integrationplugin/kemoticonsintegrationplugin.h PRE-CREATION > src/integrationplugin/kemoticonsintegrationplugin.cpp PRE-CREATION > src/integrationplugin/ktexttohtml.h PRE-CREATION > src/integrationplugin/ktexttohtml.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121118/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Vrátil > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
