----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121118/#review70817 -----------------------------------------------------------
autotests/CMakeLists.txt <https://git.reviewboard.kde.org/r/121118/#comment49527> you changed the way the macro works, I suggest changing the name accordingly: kemoticons_unit_test, for instance. This will leave room for a several-programs macro one day if needed. autotests/ktexttohtmlplugintest.cpp <https://git.reviewboard.kde.org/r/121118/#comment49528> Common mistake: this includes all of the QtTest framework *and* all of the QtCore framework. You probably want <QTest> instead. autotests/ktexttohtmlplugintest.cpp <https://git.reviewboard.kde.org/r/121118/#comment49530> s/Q_ASSERT/QVERIFY/ autotests/ktexttohtmlplugintest.cpp <https://git.reviewboard.kde.org/r/121118/#comment49529> should be const src/integrationplugin/ktexttohtml.cpp <https://git.reviewboard.kde.org/r/121118/#comment49532> Can this change at runtime? The cache would break that. (but see below) src/integrationplugin/ktexttohtml.cpp <https://git.reviewboard.kde.org/r/121118/#comment49534> It looks like emoticons.theme() would do the same, without the caching problem. - David Faure On Nov. 14, 2014, 12:36 p.m., Daniel Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121118/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 12:36 p.m.) > > > Review request for KDE Frameworks, Albert Astals Cid and David Faure. > > > Repository: kemoticons > > > Description > ------- > > This patch is related to /r/121094, which moves KTextToHTML conversion > utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on > KEmoticons needed for smileys conversion, I created a plugin in KEmoticons > that implements the interface from KCoreAddons. This is based on the > FrameworkIntegrationPlugin. > > > Diffs > ----- > > CMakeLists.txt 1550bfe > autotests/CMakeLists.txt 29b7eb6 > autotests/ktexttohtmlplugintest.cpp PRE-CREATION > src/CMakeLists.txt 7b10087 > src/integrationplugin/CMakeLists.txt PRE-CREATION > src/integrationplugin/kemoticonsintegrationplugin.h PRE-CREATION > src/integrationplugin/kemoticonsintegrationplugin.cpp PRE-CREATION > src/integrationplugin/ktexttohtml.h PRE-CREATION > src/integrationplugin/ktexttohtml.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121118/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Vrátil > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
