----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122181/#review74529 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On Jan. 21, 2015, 2:47 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122181/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 2:47 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kunitconversion > > > Description > ------- > > > This is probably a mistake when implementing the private class. Both > UnitCategoryPrivate::convert and UnitCategory::convert essentially > the same thing. However, all sub categories modify the > UnitCategoryPrivate virtual method, so we should be calling that one. > > > This was caught while trying to debug the currency converter. It has its > own custom convert function. > > > Diffs > ----- > > src/unitcategory.cpp c34217e > > Diff: https://git.reviewboard.kde.org/r/122181/diff/ > > > Testing > ------- > > Fixes a test in another patch. > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
