-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122181/
-----------------------------------------------------------
(Updated Jan. 23, 2015, 12:10 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: kunitconversion
Description
-------
This is probably a mistake when implementing the private class. Both
UnitCategoryPrivate::convert and UnitCategory::convert essentially
the same thing. However, all sub categories modify the
UnitCategoryPrivate virtual method, so we should be calling that one.
This was caught while trying to debug the currency converter. It has its
own custom convert function.
Diffs
-----
src/unitcategory.cpp c34217e
Diff: https://git.reviewboard.kde.org/r/122181/diff/
Testing
-------
Fixes a test in another patch.
Thanks,
Vishesh Handa
_______________________________________________
Kde-frameworks-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
