> On April 22, 2015, 10:53 a.m., Matthew Dawson wrote: > > src/kconfig_compiler/kconfig_compiler.cpp, line 100 > > <https://git.reviewboard.kde.org/r/123367/diff/3/?file=361168#file361168line100> > > > > Is there a reason not to generate Q_PROPERTIES for all classes, or at > > least do it by default? This seems like a useful thing to have every class > > use, so adding another configuration only reduces its visibility. > > Aleix Pol Gonzalez wrote: > To minimize changes. I agree it would be interesting, I can do it if you > (collectively) are on board. > > Do you have an idea of what should the setting be called instead? > DoNotGenerateProperties? > > Matthew Dawson wrote: > I'd just change the default to be true. Based upon what I remember about > UX, double negatives should be avoided. > > Aleix Pol Gonzalez wrote: > Ok, let's do it in a separate iteration of the patch though. This is > going to make a huge patch as it will require changing most of the unit tests.
Ok, sounds good. For that patch, it would be good to leave some unit tests not generating properties, to ensure the negative works as well. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79346 ----------------------------------------------------------- On April 22, 2015, 10:51 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123367/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 10:51 a.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > The generation of those classes makes it useful to have these being used > within C++ application. This change makes it possible to use these classes > from QML as well. > > For each variable, exposes the getter. In case there's a setter, it will add > a notify signal and the setter to the property. > > > Diffs > ----- > > autotests/kconfig_compiler/CMakeLists.txt 0cca605 > autotests/kconfig_compiler/kconfigcompiler_test.cpp 43623ce > autotests/kconfig_compiler/test13.cpp.ref PRE-CREATION > autotests/kconfig_compiler/test13.h.ref PRE-CREATION > autotests/kconfig_compiler/test13.kcfg PRE-CREATION > autotests/kconfig_compiler/test13.kcfgc PRE-CREATION > autotests/kconfig_compiler/test13main.cpp PRE-CREATION > autotests/kconfig_compiler/test_signal.cpp.ref 58e73ef > autotests/kconfig_compiler/test_signal.h.ref 19b8b40 > src/kconfig_compiler/kconfig_compiler.cpp 5aae340 > > Diff: https://git.reviewboard.kde.org/r/123367/diff/ > > > Testing > ------- > > KConfig tests still pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
