----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79403 -----------------------------------------------------------
autotests/kconfig_compiler/test13.cpp.ref (line 18) <https://git.reviewboard.kde.org/r/123367/#comment54237> This doesn't actually use the notifyFunction from above, so any external changes are not seen when the class is reloaded. Also, reusing the notify function in this manner will only cause the signal to trigger when the class is saved, AFAICS. I think just moving the emission of brightnessModified to itemChanged would work, along with an equality check. Thanks for bearing with me on all these changes :) - Matthew Dawson On April 22, 2015, 9:20 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123367/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 9:20 p.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > The generation of those classes makes it useful to have these being used > within C++ application. This change makes it possible to use these classes > from QML as well. > > For each variable, exposes the getter. In case there's a setter, it will add > a notify signal and the setter to the property. > > > Diffs > ----- > > autotests/kconfig_compiler/CMakeLists.txt 0cca605 > autotests/kconfig_compiler/kconfigcompiler_test.cpp 43623ce > autotests/kconfig_compiler/test13.cpp.ref PRE-CREATION > autotests/kconfig_compiler/test13.h.ref PRE-CREATION > autotests/kconfig_compiler/test13.kcfg PRE-CREATION > autotests/kconfig_compiler/test13.kcfgc PRE-CREATION > autotests/kconfig_compiler/test13main.cpp PRE-CREATION > autotests/kconfig_compiler/test_signal.cpp.ref 58e73ef > autotests/kconfig_compiler/test_signal.h.ref 19b8b40 > src/kconfig_compiler/kconfig_compiler.cpp 5aae340 > > Diff: https://git.reviewboard.kde.org/r/123367/diff/ > > > Testing > ------- > > KConfig tests still pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
