-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124983/
-----------------------------------------------------------
Review request for KDE Frameworks and David Faure.
Bugs: 349654
https://bugs.kde.org/show_bug.cgi?id=349654
Repository: kio
Description
-------
Currently, the standard entries of KNewFileMenu are in lib/konq in the
kde-baseapps repository, which has no released KF5 version. Therefore, the menu
is empty now for most users. Those who build their KDE software with
kdesrc-build, whose standard KF5 config includes kde-baseapps, might now have
noticed the issue yet.
This patch simply moves the relevant files to kio. Some questions that might be
worth discussing:
* Is kio considered the correct place for this, or should the files be in
kio-extras?
* Are all the menu entries still relevant, or should some be removed or
modified?
* Is it OK to move the desktop files including translations, or will this
confuse the i18n infrastructure that our brave translators use?
Diffs
-----
src/CMakeLists.txt a1d644d
src/new_file_templates/CAMERA-Device.desktop PRE-CREATION
src/new_file_templates/CDROM-Device.desktop PRE-CREATION
src/new_file_templates/CDWRITER-Device.desktop PRE-CREATION
src/new_file_templates/CMakeLists.txt PRE-CREATION
src/new_file_templates/DVDROM-Device.desktop PRE-CREATION
src/new_file_templates/Directory.desktop PRE-CREATION
src/new_file_templates/Floppy.desktop PRE-CREATION
src/new_file_templates/HD.desktop PRE-CREATION
src/new_file_templates/HTMLFile.desktop PRE-CREATION
src/new_file_templates/HTMLFile.html PRE-CREATION
src/new_file_templates/MO-Device.desktop PRE-CREATION
src/new_file_templates/NFS.desktop PRE-CREATION
src/new_file_templates/Program.desktop PRE-CREATION
src/new_file_templates/TextFile.desktop PRE-CREATION
src/new_file_templates/TextFile.txt PRE-CREATION
src/new_file_templates/URL.desktop PRE-CREATION
src/new_file_templates/ZIP-Device.desktop PRE-CREATION
src/new_file_templates/linkCAMERA.desktop PRE-CREATION
src/new_file_templates/linkCDROM.desktop PRE-CREATION
src/new_file_templates/linkCDWRITER.desktop PRE-CREATION
src/new_file_templates/linkDVDROM.desktop PRE-CREATION
src/new_file_templates/linkFloppy.desktop PRE-CREATION
src/new_file_templates/linkHD.desktop PRE-CREATION
src/new_file_templates/linkMO.desktop PRE-CREATION
src/new_file_templates/linkNFS.desktop PRE-CREATION
src/new_file_templates/linkPath.desktop PRE-CREATION
src/new_file_templates/linkProgram.desktop PRE-CREATION
src/new_file_templates/linkURL.desktop PRE-CREATION
src/new_file_templates/linkZIP.desktop PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/124983/diff/
Testing
-------
I disabled the build of kde-baseapps locally. The "Create New..." menu was
empty then, but it is populated again with this patch.
Thanks,
Frank Reininghaus
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
