> On Set. 21, 2015, 9:38 a.m., David Faure wrote: > > Hi, thanks for that. Some feedback (sorry for the delay) > > > > 1) kio is fine. kio-extras exists because some things in there bring > > additional dependencies. > > > > 2) I think we should remove all devices. Not just floppy ;) but in general, > > the way to use devices in KDE is no longer to create a desktop file for > > them (for explicit mount/unmount), but rather to use the GUI provided on > > top of Solid (in the systray; in dolphin; etc). I wonder if anyone still > > uses device desktop files? AFAIU you need an entry in fstab to be able to > > mount anything as a user, and the places model in dolphin shows everything > > from fstab... > > > > 3) No confusion will happen, but the translations will have to be redone, > > unless some brave soul performs the necessary operations on the l10n module. > > You could ask Luigi Toscano (iirc). In any case, commit this in the 2 weeks > > after a KF release rather than in the two weeks before the next one, > > to give translators time to catch up.
We can merge the translations of the desktop files from kde-baseapps. Only question mark, the license: the translations for these messages are currently merged with the translations of all .desktop files from kde-baseapps. But given that they are translations of messages from lib/konq, which seems to be LGPL, it should be fine, right? - Luigi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124983/#review85711 ----------------------------------------------------------- On Ago. 29, 2015, 8:23 p.m., Frank Reininghaus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124983/ > ----------------------------------------------------------- > > (Updated Ago. 29, 2015, 8:23 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 349654 > https://bugs.kde.org/show_bug.cgi?id=349654 > > > Repository: kio > > > Description > ------- > > Currently, the standard entries of KNewFileMenu are in lib/konq in the > kde-baseapps repository, which has no released KF5 version. Therefore, the > menu is empty now for most users. Those who build their KDE software with > kdesrc-build, whose standard KF5 config includes kde-baseapps, might now have > noticed the issue yet. > > This patch simply moves the relevant files to kio. Some questions that might > be worth discussing: > > * Is kio considered the correct place for this, or should the files be in > kio-extras? > * Are all the menu entries still relevant, or should some be removed or > modified? > * Is it OK to move the desktop files including translations, or will this > confuse the i18n infrastructure that our brave translators use? > > > Diffs > ----- > > src/CMakeLists.txt a1d644d > src/new_file_templates/CAMERA-Device.desktop PRE-CREATION > src/new_file_templates/CDROM-Device.desktop PRE-CREATION > src/new_file_templates/CDWRITER-Device.desktop PRE-CREATION > src/new_file_templates/CMakeLists.txt PRE-CREATION > src/new_file_templates/DVDROM-Device.desktop PRE-CREATION > src/new_file_templates/Directory.desktop PRE-CREATION > src/new_file_templates/Floppy.desktop PRE-CREATION > src/new_file_templates/HD.desktop PRE-CREATION > src/new_file_templates/HTMLFile.desktop PRE-CREATION > src/new_file_templates/HTMLFile.html PRE-CREATION > src/new_file_templates/MO-Device.desktop PRE-CREATION > src/new_file_templates/NFS.desktop PRE-CREATION > src/new_file_templates/Program.desktop PRE-CREATION > src/new_file_templates/TextFile.desktop PRE-CREATION > src/new_file_templates/TextFile.txt PRE-CREATION > src/new_file_templates/URL.desktop PRE-CREATION > src/new_file_templates/ZIP-Device.desktop PRE-CREATION > src/new_file_templates/linkCAMERA.desktop PRE-CREATION > src/new_file_templates/linkCDROM.desktop PRE-CREATION > src/new_file_templates/linkCDWRITER.desktop PRE-CREATION > src/new_file_templates/linkDVDROM.desktop PRE-CREATION > src/new_file_templates/linkFloppy.desktop PRE-CREATION > src/new_file_templates/linkHD.desktop PRE-CREATION > src/new_file_templates/linkMO.desktop PRE-CREATION > src/new_file_templates/linkNFS.desktop PRE-CREATION > src/new_file_templates/linkPath.desktop PRE-CREATION > src/new_file_templates/linkProgram.desktop PRE-CREATION > src/new_file_templates/linkURL.desktop PRE-CREATION > src/new_file_templates/linkZIP.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124983/diff/ > > > Testing > ------- > > I disabled the build of kde-baseapps locally. The "Create New..." menu was > empty then, but it is populated again with this patch. > > > Thanks, > > Frank Reininghaus > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel