> On Oct. 29, 2015, 8:26 p.m., Aleix Pol Gonzalez wrote: > > autotests/kdeplatformtheme_unittest.cpp, line 237 > > <https://git.reviewboard.kde.org/r/125877/diff/1/?file=413361#file413361line237> > > > > What does `qApp->wheelScrollLines()` return now? > > David Rosca wrote: > It returned the value I have set in mouse kcm, because the test > KdePlatformTheme is not installed to qApp (and WheelScrollLines is now set as > themeHint instead of directly calling qApp->setWheelScrollLines) > > Aleix Pol Gonzalez wrote: > So the behavior on all applications that used qApp->wheelScrollLines() > changed now? > > David Rosca wrote: > No, it just can't be set with QApplication::setWheelScrollLines (from > KdePlatformTheme constructor) because QApplication is querying QPlatformTheme > for the value. > > That is with Qt 5.5, older version didn't have the WheelScrollLines hint. > > Marco Martin wrote: > if QApplication is querying QPlatformTheme for wheelScrollLines(), why do > you have to use themeHint directly? > > David Rosca wrote: > Because that's what this autotest is doing (see how the other themeHints > are tested above). It just tests if the KdePlatformTheme correctly gets the > value from config.
So why not test both, i.e. turn #else into #endif? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125877/#review87695 ----------------------------------------------------------- On Oct. 29, 2015, 8:22 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125877/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 8:22 p.m.) > > > Review request for KDE Frameworks. > > > Repository: frameworkintegration > > > Description > ------- > > see summary > > > Diffs > ----- > > autotests/kdeplatformtheme_unittest.cpp f660ffd > > Diff: https://git.reviewboard.kde.org/r/125877/diff/ > > > Testing > ------- > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
