----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125877/#review88135 -----------------------------------------------------------
Ship it! Thanks !! - David Faure On Nov. 7, 2015, 12:10 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125877/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2015, 12:10 p.m.) > > > Review request for KDE Frameworks. > > > Repository: frameworkintegration > > > Description > ------- > > Use Q_CONSTRUCTOR_FUNCTION for prepareEnvironment, so the QApplication's > platform theme is using the test paths. > > This also fixes updating the WheelScrollLines when the settings change, > because QApplication is only using theme hint on startup. If the value > changes, we need to call QApplication::setWheelScrollLines instead of just > updating the theme hint. > > > Diffs > ----- > > autotests/kdeplatformtheme_unittest.cpp f660ffd > src/platformtheme/khintssettings.cpp 14e1d43 > > Diff: https://git.reviewboard.kde.org/r/125877/diff/ > > > Testing > ------- > > Tests pass > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel