----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127911/#review95485 -----------------------------------------------------------
Looks good :) A couple of questions: - If we create the .rcc do we also want to install the icons? - I creates a similar solution for Kate on Windows (in a separate repo), but I needed to add a program to replace the symlinked files with aliases in the .qrc as symlinks do not work properly on windows. Are you interested in adding a similar program/script/... to do the same directly in breeze-icons.git? My application is in git://anongit.kde.org/scratch/sars/kate-windows.git (icon-rcc) - Kåre Särs On May 14, 2016, 8:27 a.m., Gleb Popov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127911/ > ----------------------------------------------------------- > > (Updated May 14, 2016, 8:27 a.m.) > > > Review request for KDE Frameworks. > > > Repository: breeze-icons > > > Description > ------- > > I copied icons into the binary dir, because i haven't found a way to generate > rcc without polluting source dir. > > Not sure if installation dir is right, too. > > > Diffs > ----- > > icons/CMakeLists.txt 5ded49c > > Diff: https://git.reviewboard.kde.org/r/127911/diff/ > > > Testing > ------- > > > Thanks, > > Gleb Popov > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
