----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128888/ -----------------------------------------------------------
Review request for KDE Frameworks and Pinak Ahuja. Repository: kfilemetadata Description ------- Improve epub extractor: 1) check for more nullpointers (e.g. data can be null for some fields, iterators, ...) 2) actually close the epub file again at all 3) iterator seems to handle clink as stated in docs, fix double free e.g. see bug 361727 could be the double freed clink in the last iterator https://bugs.kde.org/show_bug.cgi?id=361727 Diffs ----- src/extractors/epubextractor.cpp 88a4caa Diff: https://git.reviewboard.kde.org/r/128888/diff/ Testing ------- Unit test still works, no idea how to craft files broken enough to trigger the faults Thanks, Christoph Cullmann
