----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128888/#review99100 -----------------------------------------------------------
Ship it! It looks sane enough to me. I'm going to assume you tested things and nothing obvious regressed, and give you the ship-it. I'm also very interested in knowing how we have come about having a variable called `tit` ;-) - Boudhayan Gupta On Sept. 11, 2016, 10:32 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128888/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2016, 10:32 p.m.) > > > Review request for KDE Frameworks, Boudhayan Gupta and Pinak Ahuja. > > > Repository: kfilemetadata > > > Description > ------- > > Improve epub extractor: > > 1) check for more nullpointers (e.g. data can be null for some fields, > iterators, ...) > 2) actually close the epub file again at all > 3) iterator seems to handle clink as stated in docs, fix double free > > e.g. see bug 361727 > could be the double freed clink in the last iterator > > https://bugs.kde.org/show_bug.cgi?id=361727 > > > Diffs > ----- > > src/extractors/epubextractor.cpp 88a4caa > > Diff: https://git.reviewboard.kde.org/r/128888/diff/ > > > Testing > ------- > > Unit test still works, no idea how to craft files broken enough to trigger > the faults > > > Thanks, > > Christoph Cullmann > >
