-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129395/#review100832
-----------------------------------------------------------



Can you attach a screenshot? Also the kpropertiesdialog cpp diff is messed up 
and the KRun one should be in a separate review imho

- Kai Uwe Broulik


On Nov. 14, 2016, 8:25 vorm., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129395/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2016, 8:25 vorm.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This patch adds option to run certain application on a discrete graphics card 
> (if there is any). I also modified KRun::runApplicationImpl() to take this 
> option into account when running application.
> 
> 
> Diffs
> -----
> 
>   src/widgets/kpropertiesdesktopadvbase.ui 4d2a73d 
>   src/widgets/kpropertiesdialog.cpp 18c8479 
>   src/widgets/krun.cpp d93b1f2 
> 
> Diff: https://git.reviewboard.kde.org/r/129395/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Reply via email to