----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129395/#review100990 -----------------------------------------------------------
Looks like I took too much time to review this, the patch to the .cpp file doesn't apply anymore and reviewboard refuses to show it. Can you rebase it? src/widgets/kpropertiesdesktopadvbase.ui (line 158) <https://git.reviewboard.kde.org/r/129395/#comment67727> typo: regargin -> regarding - David Faure On Nov. 14, 2016, 9:52 a.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129395/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 9:52 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > This patch adds option to run certain application on a discrete graphics card > (if there is any). I also modified KRun::runApplicationImpl() to take this > option into account when running application. > > > Diffs > ----- > > src/widgets/kpropertiesdesktopadvbase.ui 4d2a73d > src/widgets/kpropertiesdialog.cpp 18c8479 > > Diff: https://git.reviewboard.kde.org/r/129395/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Screenshot of KPropertiesDialog > > https://git.reviewboard.kde.org/media/uploaded/files/2016/11/14/89203f95-9267-47db-b2ad-0eeb42357a1c__kpropertiesdialog.png > > > Thanks, > > Jan Grulich > >
