----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129798/ -----------------------------------------------------------
(Updated Jan. 15, 2017, 4:03 p.m.) Review request for Baloo and KDE Frameworks. Changes ------- Added one more test for m4a file format Repository: kfilemetadata Description ------- Musepack extraction of album artist was using the wrong tag name (tested against easytag and picard). See also this page (http://taglib.org/api/classTagLib_1_1APE_1_1Tag.html) that seems to indicate that APE is using "ALBUM ARTIST" with a space between both words. Diffs (updated) ----- autotests/samplefiles/test.flac PRE-CREATION autotests/samplefiles/test.m4a PRE-CREATION autotests/samplefiles/test.mp3 PRE-CREATION autotests/samplefiles/test.mpc PRE-CREATION autotests/samplefiles/test.ogg PRE-CREATION autotests/taglibextractortest.cpp d46e49e src/extractors/taglibextractor.cpp 8fcad93 Diff: https://git.reviewboard.kde.org/r/129798/diff/ Testing ------- I have tested with automatic tests of KFileMetaData and also the encoding problem in Musepack format against Easytag and Picard applications. Thanks, Matthieu Gallien
