gszymaszek marked 6 inline comments as done. gszymaszek added inline comments.
INLINE COMMENTS > dhaumann wrote in editorconfig.cpp:23 > Better is to write: > > EditorConfig::EditorConfig(KTextEditor::DocumentPrivate *document) > : m_document(document) > , m_handle(0) > { > // ... > } Is it OK to initialize `m_handle` in the constructor? If so, is `m_handle(0)` necessary? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4537 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: gszymaszek, #ktexteditor Cc: dhaumann, kwrite-devel, #frameworks