mdawson requested changes to this revision. mdawson added a comment. This revision now requires changes to proceed.
I agree, this can't be used so removing it from the API can't hurt anything. Just to be sure, let's take this change for the next release, but not change KConfigBackend' API/ABI until after the next release. If anyone complains about KConfigBackend missing before then, we can just re-export it easily. Otherwise this can always come back in a (ABI) different form if this ever becomes worthwhile. Does that sound good to you? I do have one small comment before committing. INLINE COMMENTS > kconfigbackend.h:210 > +//#define K_EXPORT_KCONFIGBACKEND(libname, classname) \ > +// K_PLUGIN_FACTORY(factory, registerPlugin<classname>();) > I don't think this is worth saving as a comment, just remove it completely. If we decide to undo this, it's in git. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D4604 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, mdawson Cc: #frameworks
