dfaure added a comment.
The plan sounds good.
INLINE COMMENTS
> mdawson wrote in kconfigbackend.h:210
> I don't think this is worth saving as a comment, just remove it completely.
> If we decide to undo this, it's in git.
In general I agree that leaving dead code is bad.
In this particular case, though, the other side of the plugin code is still
there
("#if 0 // TODO port to Qt5 plugin loading" in kconfigbackend.cpp), and
actually this is the bit that *was* ported to Qt5 plugin loading, so it will be
useful if anyone decides to finally implement plugin based backends. Maybe I
can make it
#if 0 // TODO re-enable if the plugin loading code is re-enabled
instead of just "//" which is indeed uglier.
Alternatively, we decide that plugin-based backends are not even on the
far-future radar and we clean up both sides completely. Works for me too. The
whole idea was crazy anyway (apps make assumptions about config files being
files, if one day we change that for e.g. something like gconf then it won't be
as transparent as just switching to a different backend).
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D4604
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dfaure, mdawson
Cc: #frameworks
