dfaure added inline comments.
INLINE COMMENTS
> kprotocolmanager.cpp:846
> d->useragent += QString::number(KIO_VERSION_MAJOR);
> + d->useragent += QStringLiteral(" kio_http/");
> + d->useragent += QString::number(KIO_VERSION_MAJOR);
How about just KIO ?
kio_http is unnecessarily specific IMHO. It's all of KIO/5.33 that ends up
making up the http client.
> cache.cpp:109
> return i18n( "<h1>Cache</h1><p>This module lets you configure your cache
> settings.</p>"
> - "<p>The cache is an internal memory in Konqueror where
> recently "
> + "<p>The cache is an internal memory where recently "
> "read web pages are stored. If you want to retrieve a web "
Memory? that seems wrong (or at least misleading) to me. The kio_http cache is
on disk, not in RAM.
> ltoscano wrote in smbrodlg.cpp:176-186
> I will fix it (basically removing most of the text), but I realize now that
> this KCM should not be here. The kio_smb is in kio-extras, this code should
> be moved there.
I agree.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5090
To: ltoscano, dfaure
Cc: aacid, lueck, #frameworks
