kfunk accepted this revision. kfunk added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > cfeck wrote in kfontrequester.cpp:187 > Does removing the default value mean the flags would be now uninitialized? No, `QFontDialog::FontDialogOptions` is a `QFlags<>` which has a default constructor which initializes all members. REPOSITORY R236 KWidgetsAddons BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6053 To: kossebau, #frameworks, cfeck, kfunk Cc: kfunk