kossebau added inline comments. INLINE COMMENTS
> cfeck wrote in kfontrequester.cpp:187 > Does removing the default value mean the flags would be now uninitialized? No, the constructor called would be (as before) `QFlags::QFlags<QFontDialog::FontDialogOption>(Zero zero = Q_NULLPTR)`, so still default to 0 internally, so with no flag set. (cmp. also https://code.woboq.org/qt5/qtbase/src/corelib/global/qflags.h.html#_ZN6QFlagsC1EMNS_7PrivateEi) REPOSITORY R236 KWidgetsAddons BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6053 To: kossebau, #frameworks, cfeck, kfunk Cc: kfunk
