aacid added inline comments.
INLINE COMMENTS
> kbookmarkmanager.cpp:337
> + if (d->m_dialogAllowed && qobject_cast<QApplication *>(qApp) &&
> QThread::currentThread() == qApp->thread()) {
> + QMessageBox::critical(QApplication::activeWindow(),
> QApplication::applicationName(), err);
> + }
critical is a bit heavy in my opinion, i'd just go for warning for this and the
debug line below.
> kbookmarkmanager.cpp:341
> + qCritical() << QStringLiteral("Failed to start keditbookmarks");
> + emit const_cast<KBookmarkManager *>(this)->error(err);
> + }
Why const_cast?
REPOSITORY
R294 KBookmarks
REVISION DETAIL
https://phabricator.kde.org/D6277
To: valeriymalov, #frameworks
Cc: aacid, ltoscano
