valeriymalov marked an inline comment as done. valeriymalov added inline comments.
INLINE COMMENTS > aacid wrote in kbookmarkmanager.cpp:341 > Why const_cast? Uh oh, I'd assume startKEditBookmarks should be const (which I forgot) since it doesn't change the object, yet we need to emit non-const singal error. So should it be const or not? Also, I'm looking at slotEditBookmarks and slotEditBookmarksAtAddress, and don't understand why those weren't const, since they don't have side-effects too, although I might be missing something since I'm not too familiar with Qt. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D6277 To: valeriymalov, #frameworks Cc: aacid, ltoscano
