Present: me, chinmoy, arnav/shortstheory
Minutes are in the attachment.
P.S.
Minutes of the previous meetings were sent only to the kfm-devel list, but
that was an oversight on my part (as chinmoy's project is mainly
kio-related and so the frameworks list is the proper place).
P.P.S.
Meetings are every saturday at 10am UTC on #kde-fm, if anyone wants to join
them.
Cheers,
Elvis
2017-07-09 10:00:53 eang Meeting!
2017-07-09 10:01:12 eang chinmoy, shortsthey ?
2017-07-09 10:01:18 IrcsomeBot <shortstheory> Yo
2017-07-09 10:01:22 eang *shortstheory
2017-07-09 10:01:31 IrcsomeBot <shortstheory> I'm here
2017-07-09 10:02:07 chinmoy[m] eang: here
2017-07-09 10:02:32 eang let's start!
2017-07-09 10:03:39 chinmoy[m] this week was pretty rough on me. all i
did was bit of cleaning up of patches
2017-07-09 10:03:55 chinmoy[m] mostly I worked on dfaure's suggestions
2017-07-09 10:04:51 chinmoy[m] I can say now 90% of KIO's wwork is done
2017-07-09 10:05:23 chinmoy[m] unit tests and all the warnings and
rest of the stuffs are in place
2017-07-09 10:05:35 chinmoy[m] only thing left is prepare proper
patches
2017-07-09 10:06:01 chinmoy[m] and unlocking of kauth actions
2017-07-09 10:06:18 chinmoy[m] that is all
2017-07-09 10:06:28 IrcsomeBot <shortstheory> sounds good
2017-07-09 10:06:43 eang have you fixed the BIC issue pointer by david?
2017-07-09 10:07:14 chinmoy[m] I created a separate class inheriting
from jobuidelegate
2017-07-09 10:07:20 eang *pointed
2017-07-09 10:07:40 IrcsomeBot <shortstheory> what issue?
2017-07-09 10:08:15 eang https://phabricator.kde.org/D6197#inline-26630
2017-07-09 10:08:16 sKreamer Diff 6197 "Add basic KAuth support to
file ioslave" [Needs Revision] https://phabricator.kde.org/D6197
2017-07-09 10:08:46 chinmoy[m] a separate class should do right?
2017-07-09 10:10:14 chinmoy[m] ok I haven't updated the patch so you
might not be able to tell.
2017-07-09 10:13:06 chinmoy[m] I have something to ask. Consider this,
a user tries to copy a file to '/opt' but there already exists the same file
so he decides to overwrite it. now as per the code the file will be deleted and
considering it's '/opt' our helper m,ethod will be called and auth dialog will
pop up. so what message should be there?
2017-07-09 10:13:30 chinmoy[m] "copying needs privilege" or "deleting
needs privilege"?
2017-07-09 10:14:21 eang I'd say the former
2017-07-09 10:14:37 eang the fact that we delete under the hood is an
implementation detail
2017-07-09 10:16:37 chinmoy[m] so the exact reason why password is
being asked should'nt be shown?
2017-07-09 10:17:53 IrcsomeBot <shortstheory> Yup
2017-07-09 10:17:54 chinmoy[m] say if a user tries to copy a large
directory which happens to have one file with read access restricted then won't
it add to unnecessary confusion?
2017-07-09 10:22:28 chinmoy[m] eang, shortheory: apart from this have
you any ideas whether dolphin has some kind of restrictions on its plugins or
not?
2017-07-09 10:23:09 IrcsomeBot <shortstheory> No restrictions in my
experience
2017-07-09 10:23:30 IrcsomeBot <shortstheory> Though most of my work
was actually changing parts of dolphin than optional plugins
2017-07-09 10:23:32 eang it runs whatever plugins are installed in the
proper place
2017-07-09 10:23:47 IrcsomeBot <shortstheory> And Emmanuel approved
all of those readily
2017-07-09 10:24:25 IrcsomeBot <shortstheory> What plugins would we
need here?
2017-07-09 10:24:55 chinmoy[m] if privileges are elevated for a brief
time period will a plugin be able to do whatever it wants?
2017-07-09 10:25:55 IrcsomeBot <shortstheory> not too sure about that
2017-07-09 10:25:58 eang yes, the plugins are part of the dolphin
process, so if they use KIO::del that could be a problem
2017-07-09 10:27:06 chinmoy[m] I really can't get my head around this
2017-07-09 10:27:52 chinmoy[m] it seems we have to remove the
persistence
2017-07-09 10:28:39 chinmoy[m] thats about the only solution I could
come up with.
2017-07-09 10:32:18 eang what about removing the "don't ask again"
checkbox?
2017-07-09 10:33:50 chinmoy[m] the dialog won't be having one but its
called from the client thus the client can choose to skip the dialog altogether
2017-07-09 10:34:59 eang client = malicious plugin, in this case?
2017-07-09 10:35:09 chinmoy[m] yes
2017-07-09 10:36:44 eang we probably need a workspace-level solution,
removing the perstistence would be annoying imho
2017-07-09 10:37:11 chinmoy[m] I tried it and it was frustrating
2017-07-09 10:37:24 chinmoy[m] is it possible to generate some kind of
uid before calling the job?
2017-07-09 10:37:48 eang I wonder if kio could check whether 3d-party
plugins have been installed
2017-07-09 10:38:35 --> pursuivant
(pursuivant@kde/bot/commit-notifications) has joined #kde-fm
2017-07-09 10:38:35 pursuivant konqueror (master)
v17.04.1-25-g997541a6a * David Faure: client (5 files)
2017-07-09 10:38:36 pursuivant Move code that talks to a running konq
(or starts one) into a separate class.
2017-07-09 10:38:37 pursuivant The intention was to put that in
libkonq and use it in konqueror,
2017-07-09 10:38:37 pursuivant but after all, KDBusService::Unique is
better suited for that.
2017-07-09 10:38:38 pursuivant
https://commits.kde.org/konqueror/997541a6a64bc1aa79a71fe7c94fb1e5e1c765a9
2017-07-09 10:38:42 pursuivant konqueror (master)
v17.04.1-27-g3c58b0b04 * David Faure: src/konqmainwindowfactory.cpp
2017-07-09 10:38:42 pursuivant Make preloading do something again,
even in a single-process situation.
2017-07-09 10:38:43 pursuivant
https://commits.kde.org/konqueror/3c58b0b0452a468b356859eb51041a46160fbff6
2017-07-09 10:38:50 pursuivant konqueror (master)
v17.04.1-26-g736b74509 * David Faure: (7 files in 2 dirs)
2017-07-09 10:38:51 pursuivant Make Konqueror a KUniqueApplication, as
QtWebEngine expects.
2017-07-09 10:38:52 pursuivant Using QtWebEngine (with the same
profile, i.e. local directory
2017-07-09 10:38:52 pursuivant for cookies and visited links history
etc.) from several processes
2017-07-09 10:38:53 pursuivant hits many issues (file corruption,
asserts, etc.).
2017-07-09 10:38:53 pursuivant
https://commits.kde.org/konqueror/736b74509189e110c9605fc1a37fcab9bdcc1aa9
2017-07-09 10:40:03 <-- IrcsomeBot (telegram@kde/bot/telegram-relay)
has quit (Remote host closed the connection)
2017-07-09 10:40:26 chinmoy[m] don't know
2017-07-09 10:40:27 --> IrcsomeBot (telegram@kde/bot/telegram-relay)
has joined #kde-fm
2017-07-09 10:40:32 eang or maybe it should be done from the dolphin side
2017-07-09 10:40:48 eang "hey, I have random plugins installed, please
don't enable persistence"
2017-07-09 10:40:57 pursuivant konqueror (master)
v17.04.1-28-gb961789fc * David Faure: client/konqclientrequest.cpp
2017-07-09 10:40:57 pursuivant add missing license
2017-07-09 10:40:58 pursuivant
https://commits.kde.org/konqueror/b961789fcaa4a02103849e1b25f799747d4a8315
2017-07-09 10:41:48 chinmoy[m] in theory it sounds good
2017-07-09 10:42:14 chinmoy[m] is there any tutorial for writing
dolphin plugins?
2017-07-09 10:42:28 IrcsomeBot <shortstheory> Better to do it from the
dolphin side.
2017-07-09 10:42:49 IrcsomeBot <shortstheory> Why not put it part of
the mainline dolphin code though?
2017-07-09 10:43:52 chinmoy[m] I want to see for myself what can or
cannot be done with dolphin plugins. any links?
2017-07-09 10:44:17 IrcsomeBot <shortstheory> check kde:dolphin-plugins
2017-07-09 10:44:18 eang I'm not aware of tutorials, but it's not too
hard
2017-07-09 10:44:27 eang I can link you to existing plugins as example
2017-07-09 10:44:41 IrcsomeBot <shortstheory>
https://github.com/KDE/dolphin-plugins
2017-07-09 10:45:24 chinmoy[m] ok i will test it
2017-07-09 10:46:05 IrcsomeBot <shortstheory> if this gets shipped
with KIO anyway, i feel it is better to modify dolphin directly for support
2017-07-09 10:47:17 chinmoy[m] I just hope i don't have to make
drastic changes to my approach
2017-07-09 10:47:47 chinmoy[m] one last thing, i was thinking of
adding another metadata, something like "UsePrivilege".
2017-07-09 10:48:17 IrcsomeBot <shortstheory> not really, dolphin
source is well organised
2017-07-09 10:49:21 eang what I was thinking is expanding the
PrivilegeConfType enum with something like "PrivilegeDeleteWithPesistence"
2017-07-09 10:49:55 eang so clients would have to explicitly opt-in into
the persistence mode, if they are confident
2017-07-09 10:50:03 <-- IrcsomeBot (telegram@kde/bot/telegram-relay)
has quit (Remote host closed the connection)
2017-07-09 10:50:26 --> IrcsomeBot (telegram@kde/bot/telegram-relay)
has joined #kde-fm
2017-07-09 10:50:41 eang but I'm not sure if this would be possible
2017-07-09 10:51:40 chinmoy[m] well its the KIO job that matters
2017-07-09 10:52:01 chinmoy[m] that's i thought of adding that metadata
2017-07-09 10:52:37 chinmoy[m] then, as you said client will have to
choose whether or not they want privileged execution
2017-07-09 10:52:42 eang yes that additional metadata would be needed on
the ioslave level
2017-07-09 10:53:10 chinmoy[m] with this the existing unit tests won't
fails as well
2017-07-09 10:56:18 chinmoy[m] shortstheory: I was able to transfer
file descriptors using dbus. I overlooked the fact that different users can't
interact on session bus. so I had to set euid of helper process to the current
user's and then everything worked flawlessly
2017-07-09 10:56:41 chinmoy[m] though i have to mention the code was
nasty
2017-07-09 10:57:17 chinmoy[m] anyway I will upload that patch soon
and will mention my findings\
2017-07-09 10:58:23 IrcsomeBot <shortstheory> Interesting approach!
2017-07-09 10:58:45 chinmoy[m] rather its the only approach
2017-07-09 10:59:45 chinmoy[m] but thiago metioned its not safe to run
that much qt code as root though he didn't mention why
2017-07-09 11:01:29 chinmoy[m] eang, shortstheory: I don't think I
have anything else to report
2017-07-09 11:01:33 IrcsomeBot <shortstheory> It's not a good idea to
run code using large libraries as root because if there are any bugs in Qt
(there are), those bugs can do nasty things
2017-07-09 11:02:16 chinmoy[m] hmm.. thats why the suggestion of using
systemd library
2017-07-09 11:02:45 IrcsomeBot <shortstheory> Yeah, upload the patch
soon, let's try to make it better
2017-07-09 11:03:11 chinmoy[m] I am on it
2017-07-09 11:03:46 IrcsomeBot <shortstheory> will you be filing a new
request on phabricator or to the same one?
2017-07-09 11:03:46 chinmoy[m] so meeting's over i guess?
2017-07-09 11:04:34 chinmoy[m] shorts theory: new one. RFC patch.
2017-07-09 11:05:06 eang yes, meeting over if you don't have anything
else to report
2017-07-09 11:05:36 chinmoy[m] nothing from my side.
2017-07-09 11:06:25 eang next meeting on saturday 15th
2017-07-09 11:07:08 IrcsomeBot <shortstheory> sure