dhaumann added a comment.
Looks already good, but maybe we can do better with the lineEmptyContext? Also, we have things like fallthroughContext, if no rule matches at all in a context. I suggest one more review iteration. INLINE COMMENTS > email.xml:51 > + <keyword attribute="Common Header" context="header-content" > String="header-names" column="0"/> > + <RegExpr attribute="Other Header" context="header-content" > String="[0-9a-zA-Z-.]+:\s" column="0"/> > + <!-- we would want to switch to a body context here when > encountering an empty newline, but that's not supported, is it? --> Not sure, but is underscore '_' also allowed? > email.xml:52 > + <RegExpr attribute="Other Header" context="header-content" > String="[0-9a-zA-Z-.]+:\s" column="0"/> > + <!-- we would want to switch to a body context here when > encountering an empty newline, but that's not supported, is it? --> > + <RegExpr attribute="Content Boundary" context="#stay" > String="--[0-9a-zA-Z.-]+(--)?$" column="0"/> Search for lineEmptyContext here: https://docs.kde.org/trunk5/en/applications/katepart/highlight.html > email.xml:60 > + <DetectChar attribute="Comment" context="comment-context" > char="("/> > + <RegExpr attribute="Address" context="#stay" > String="<?[a-zA-Z0-9.-]+@[a-zA-Z0-9.-]+>?"/> > + </context> '_' missing? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7289 To: vkrause, #framework_syntax_hightlighting, kwrite-devel Cc: dhaumann, #frameworks
