fvogt added a comment.
In https://phabricator.kde.org/D7929#147784, @ngraham wrote: > I'll just leave this here: ;-) https://bugs.kde.org/show_bug.cgi?id=290747 In https://phabricator.kde.org/D7929#147806, @dhaumann wrote: > Since this adds the column view again, how does this relate to the decision of dropping the column view back in 2012, see comment in this blog: > http://ppenz.blogspot.fr/2012/01/dolphin-20-status-update.html?showComment=1325669619833&m=1 > > Are the issues of maintenance addressed here? Dolphin has an entirely different codebase for displaying items and directories, so none of this applies to dolphin :-( To answer the maintenance burden question for KIO: There is only little added complexity here, most of it it contained within the KColumnView class. Some of the supporting code for the tree view also applies to the column view. The openURL method in KDirOperator has some simple special handling for the fixed root node (which should probably be used for the treeview as well, to have the right behaviour when clicking on directories), but that's about it. In https://phabricator.kde.org/D7929#147831, @cfeck wrote: > Exactly because of this confusion (file dialog vs. Dolphin) I would not add columns to the file dialog unless they are also implemented in Dolphin. This confusion is based on the programmer's perspective (browsing files -> same code?) and not necessarily the user's perspective. The file dialog has not nearly dolphin's amount of features, but it does not have to be. Same applies for the other direction. Having it in Dolphin as well would be great, but IMO it's entirely separate. The file dialog is made for navigating to files and dolphin is made for managing files. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7929 To: fvogt, #frameworks Cc: cfeck, dhaumann, ngraham, elvisangelaccio, lbeltrame, #frameworks
