leinir added inline comments.
INLINE COMMENTS
> engine.cpp:536
> + connect(l, &ImageLoader::signalError, this, [this, l](const
> KNSCore::EntryInternal &entry, EntryInternal::PreviewType type) {
> + qCDebug(KNEWSTUFFCORE) << "ERROR preview: " << entry.name() << type;
> + --m_numPictureJobs;
You did add l to the capture, but unless i'm missing something super obvious...
you're not using it ;) i meant to do something like add `<<
l->job()->errorText()` to the debug statement so we can see what the job says
has gone wrong (which arguably is the more useful information here)...
Maybe also emit a signalError with an appropriate text (because that's how to
tell the user about errors)... though i'm not entirely certain if we might not
want to just fail quietly here.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D8811
To: anthonyfieroni, leinir, dfaure
Cc: broulik, #frameworks, ZrenBot
