anthonyfieroni added inline comments. INLINE COMMENTS
> leinir wrote in engine.cpp:536 > You did add l to the capture, but unless i'm missing something super > obvious... you're not using it ;) i meant to do something like add `<< > l->job()->errorText()` to the debug statement so we can see what the job says > has gone wrong (which arguably is the more useful information here)... > > Maybe also emit a signalError with an appropriate text (because that's how to > tell the user about errors)... though i'm not entirely certain if we might > not want to just fail quietly here. Job can be nullptr, so signal can be a text, it can capture entry by reference? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D8811 To: anthonyfieroni, leinir, dfaure Cc: broulik, #frameworks, ZrenBot
