petermajchrak added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kpropertiesdialog.cpp:2798-2804
> You don't understand me, now you have a race condition. cachedChecksum reads 
> from cache while cacheChecksum writes. It's a race condition and you need 
> mutex here. When you add here you will not needed anymore in cacheChecksum.

But adding a mutex for guarding the body of the mapper function will serialize 
the hash computations. The computations themselves are independent and 
parallelizable, only the synchronization points (cachedChecksum and 
cacheChecksum) are not.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8536

To: petermajchrak, elvisangelaccio, #vdg, colomar
Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, 
#frameworks

Reply via email to