petermajchrak added inline comments. INLINE COMMENTS
> anthonyfieroni wrote in kpropertiesdialog.cpp:2798-2804 > You don't understand me, now you have a race condition. cachedChecksum reads > from cache while cacheChecksum writes. It's a race condition and you need > mutex here. When you add here you will not needed anymore in cacheChecksum. I can add two critical sections, one for reading the cache and one for writing while the hash computation is not in either of them REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks