elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed.
All right, let's go with the combobox. Before I look into the non-ui code, please update the patch by following the Frameworks coding style: https://community.kde.org/Policies/Kdelibs_Coding_Style INLINE COMMENTS > checksumswidget.ui:58 > <widget class="QWidget" name="calculateWidget" native="true"> > - <layout class="QFormLayout" name="formLayout_2"> > - <item row="0" column="0"> > - <widget class="QLabel" name="label_2"> > + <layout class="QGridLayout" name="gridLayout"> > + <item row="1" column="0"> Please don't use a grid layout, keep the current form layout. Using a grid layout results in huge push buttons which is really ugly. Also keep in mind the HIG for label alignment: https://community.kde.org/KDE_Visual_Design_Group/HIG/Alignment > checksumswidget.ui:67 > + <item row="1" column="1"> > + <widget class="QLabel" name="valueLabel"> > <property name="text"> This label can become huge with SHA3 checksums and it will resize the dialog. Now it's probably the right time to switch to `KSqueezedTextLabel`. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
