fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> slavebase.cpp:279
> QByteArray data = d->timeoutData;
> - d->nextTimeout = QDateTime();
> + d->nextTimeout.start();
> d->timeoutData = QByteArray();
In the old code the timeout was canceled here, but now it gets started again
instead.
> slavebase.cpp:1052
> } else {
> - d->nextTimeout = QDateTime(); // Canceled
> + d->nextTimeoutMsecs = 1; // Canceled
> }
If I understand this correctly, this will change behaviour.
It'll call the timeout function on the next dispatchLoop call.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9983
To: jtamate, #frameworks, fvogt
Cc: fvogt, ngraham
