jtamate added inline comments. INLINE COMMENTS
> fvogt wrote in slavebase.cpp:279 > In the old code the timeout was canceled here, but now it gets started again > instead. Reading the documentation http://doc.qt.io/qt-5/qelapsedtimer.html I'm not able to say if start() will restart a timer or continue. My guess is that it also restarts. And also because calling restart() on a QElapsedTimer that is invalid results in undefined behavior. > fvogt wrote in slavebase.cpp:1052 > If I understand this correctly, this will change behaviour. > It'll call the timeout function on the next dispatchLoop call. | before | now | where | | next = now + timeout | msecs = timeout, (re)start elapsed | setTimeoutSpecialCommand | | if next < now then | if has elapsed timeout then | dispatchLoop | | I think both are equivalent. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9983 To: jtamate, #frameworks, fvogt Cc: fvogt, ngraham
