michaelh marked 4 inline comments as done. michaelh added inline comments. INLINE COMMENTS
> bruns wrote in advancedqueryparsertest.cpp:264 > Adds no information, just use QString() here (and twice below) This test fails. "no optimization" serves as a flag, that it's expected to fail and as message why. See lines 217-219. That's why I thought of dropping it, because D11826 <https://phabricator.kde.org/D11826> does not make it pass. If we drop this test the `failmessage` column can be removed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin
