ngraham added a comment.
Got a few code niggles, detailed below. Function-wise, this is a vast usability improvement. And in case you have a really excessively long file name, you can just use Tree view (the non-details version), which only has one column. INLINE COMMENTS > kdiroperatordetailview.cpp:35 > > KDirOperatorDetailView::KDirOperatorDetailView(QWidget *parent) : > + QTreeView(parent) Oops, we shouldn't get rid of the initialization for both of these variables, just the one for `m_resizeColumns`. Remember to remove its definition in the header file, too. > kdiroperatordetailview_p.h:56 > void expandNameColumn(); > - > +**/ > private: Don't leave code commented out like this; if it's not used anymore, delete it! > kdiroperatordetailview_p.h:58 > private: > bool m_resizeColumns; > bool m_hideDetailColumns; We don't need this anymore. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns
