bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision.
REVISION SUMMARY Term::Or and Term::And delimit the term in construction, but did not add the term to the stack. This necessitated to save the last seen operation, but use the previous operation from the stack when adding to it. Unfortunately the last seen operation was not restored correctly after pushing and popping from the stack. Instead of adding more state to the parser, immediately add a completed term to the stack, which allows to remove the temporary last operation. TEST PLAN ctest REPOSITORY R293 Baloo BRANCH t2 REVISION DETAIL https://phabricator.kde.org/D12037 AFFECTED FILES autotests/unit/lib/advancedqueryparsertest.cpp src/lib/advancedqueryparser.cpp To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin