mgallien added a comment.
In D12145#245023 <https://phabricator.kde.org/D12145#245023>, @alexeymin wrote: > Just curious, why is this needed? To avoid dynamic memory allocations? I asked on new code to avoid using an extractor allocated on heap instead of on stack. @michaelh just did the modifications in all tests to keep them coherent. To me, the allocation on heap looks absolutely overhead. REPOSITORY R286 KFileMetaData BRANCH plugin-simple (branched from master) REVISION DETAIL https://phabricator.kde.org/D12145 To: michaelh, #baloo, #frameworks, mgallien, bruns Cc: alexeymin, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns