jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision.
REVISION SUMMARY (partial patch) There is a problem converting KCoreDirLister to the new connect syntax: In void KCoreDirLister::Private::connectJob(KIO::ListJob *job) (line 2724), In the old syntax it is using **private signals** from KJob without problems. But in the new syntax this is detected by the compiler and it does not compile. One solution is to put a big TODO for KF6. Another solution could be to make the signals public. Is there another solution? TEST PLAN Try to compile, then pass the tests. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12228 AFFECTED FILES src/core/kcoredirlister.cpp src/core/kcoredirlister_p.h To: jtamate, dfaure, #frameworks Cc: michaelh, ngraham, bruns